Skip to content

Conversation

@G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jul 10, 2025

This loop is the exact same as this.#idealTreePrune:

#idealTreePrune () {
for (const node of this.idealTree.inventory.values()) {
if (node.extraneous) {
node.parent = null
}
}
}

I'm 98% sure it's a left-over from a refactor that intended to encapsulate the logic so it can be reused elsewhere

References

@G-Rath G-Rath requested a review from a team as a code owner July 10, 2025 20:16
@G-Rath G-Rath changed the title refactor: remove duplicate loop chore: remove duplicate loop Jul 10, 2025
@wraithgar wraithgar changed the title chore: remove duplicate loop fix: remove duplicate loop Jul 10, 2025
@wraithgar
Copy link
Member

Even worse it was part of a code cleanup that I apparently hit "paste" into somehow as I was doing it. Good catch.

#6393

@wraithgar wraithgar merged commit c457c75 into npm:latest Jul 10, 2025
17 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Jul 10, 2025
@G-Rath G-Rath deleted the patch-2 branch July 10, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants