fix: more lightweight npm bin discovery in windows #7271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wraithgar force-pushed the gar/cli-streamline branch from e59db0d to fee746a Compare 
wraithgar commented Mar 6, 2024
wraithgar commented Mar 6, 2024
wraithgar force-pushed the gar/cli-streamline branch from 3aaff39 to 84050e7 Compare wraithgar force-pushed the gar/cli-streamline branch from 84050e7 to 34137b3 Compare 
lukekarrys approved these changes Mar 6, 2024
Member Author
| Manually tested these in Windows by copying the new bash/cmd scripts and the new npm-prefix.js into "C:\Program files\nodejs". Works fine still. |
Merged
This was referenced Mar 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This will stop npm having to load twice on every windows invocation