allow new majors of node to be automatically considered supported #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I have no idea where the tests for this might be; happy to write some if I can be pointed in the right direction. |
mikemimik added Community Enhancement 
darcyclarke removed the Release 7.x 
| @ljharb This looks good although we may want to make a few changes. This will potentially land although we'll update the implementation a bit. Thanks! |
| @darcyclarke great! i'm happy to make the changes as well if comments are posted; either way's fine with me. |
isaacs pushed a commit that referenced this pull request Feb 25, 2020
isaacs pushed a commit that referenced this pull request Feb 25, 2020
This was referenced Mar 18, 2020
This was referenced Mar 20, 2020
This was referenced Apr 8, 2020
This was referenced Apr 17, 2020
This was referenced Feb 11, 2024
This was referenced Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What / Why
New major versions of node shouldn't be reported as "too old" or unsupported, in the absence of an explicit "known broken" declaration.
Per #696 (comment)