docs: remove package-lock option for npm ci #6468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wraithgar approved these changes May 18, 2023
wraithgar reviewed May 18, 2023
| This will also prevent _writing_ \`package-lock.json\` if \`save\` is | ||
| true. | ||
| This configuration does not affect \`npm ci\`. |
There was a problem hiding this comment.
The thinking here is that now that this isn't listed as a flag on npm ci the caveat isn't needed.
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
running
npm help ciandnpm ci --helpsuggests the optionpackage-lockand--no-package-lockrespectively, even though thenpm help ciexplicitly states that this has no effect onnpm ci.this also applies to
npm help install-ci-testandnpm install-ci-test --help.this pr would remove that unnecessary option suggestion.