Skip to content

Conversation

dwilches
Copy link
Contributor

This modification was prompted by this SO question:
https://stackoverflow.com/questions/51050008/npm-version-add-r-c-to-current-version-and-use-prerelease/51050516

Where I didn't find an alternative for adding prerelease identifiers through node version.

(PR moved from: npm/npm#21117)

@dwilches dwilches requested a review from a team as a code owner July 21, 2018 05:54
@dwilches dwilches changed the title Version preid version: allow prerelease identifier Jul 21, 2018
npm itself updates AUTHORS when we release. No need to do this in a PR.
@zkat zkat added the semver:minor new backwards-compatible feature label Jul 23, 2018
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Thanks for this. I think it's been a pain to -not- have this :)

@zkat zkat merged commit ad0dd22 into npm:release-next Jul 23, 2018
@zkat
Copy link
Contributor

zkat commented Jul 23, 2018

note: I removed your patch to AUTHORS. We have an automated script that makes sure the AUTHORS file is updated on every release, so you'll get your credit at that point :)

@dwilches
Copy link
Contributor Author

Cool! Thanks :)

isaacs added a commit that referenced this pull request Aug 12, 2019
- [`9c93ac3`](npm/cmd-shim@9c93ac3) [#2](npm/cmd-shim#2) [#3380](npm/npm#3380) Handle environment variables properly ([@basbossink](https://github.com/basbossink)) - [`2d277f8`](npm/cmd-shim@2d277f8) [#25](npm/cmd-shim#25) [#36](npm/cmd-shim#36) [#35](npm/cmd-shim#35) Fix 'no shebang' case by always providing `$basedir` in shell script ([@igorklopov](https://github.com/igorklopov)) - [`adaf20b`](npm/cmd-shim@adaf20b) [#26](npm/cmd-shim#26) Fix `$*` causing an error when arguments contain parentheses ([@satazor](https://github.com/satazor)) - [`49f0c13`](npm/cmd-shim@49f0c13) [#30](npm/cmd-shim#30) Fix paths for MSYS/MINGW bash ([@dscho](https://github.com/dscho)) - [`51a8af3`](npm/cmd-shim@51a8af3) [#34](npm/cmd-shim#34) Add proper support for PowerShell ([@ExE-Boss](https://github.com/ExE-Boss))
antongolub pushed a commit to antongolub-forks/npm-cli that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor new backwards-compatible feature

2 participants