Skip to content

Conversation

@RandomUser14
Copy link
Contributor

Description

Added support for unique_id property type to fix deserialize issue.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
@KoditkarVedant
Copy link
Contributor

@RandomUser14 could you resolve the CodeFactor warnings.

@alfadormx
Copy link

alfadormx commented Aug 30, 2023

Hello I am having issues with the unique_id as well and I see this PR could fix this issue
@RandomUser14 @KoditkarVedant , are you planning on merging this PR anytime soon? if not, which release version of Notion-dotnet shall I use ?
How come this PR has been since July?
Thanks for your kind help.

@KoditkarVedant
Copy link
Contributor

KoditkarVedant commented Sep 4, 2023

@alfadormx I'll take a look this weekend and release the latest version. Could you please take a look at one failing check.

@lejafo
Copy link

lejafo commented Sep 15, 2023

Hi!
what's the status of this PR?

@KoditkarVedant KoditkarVedant merged commit dd5a5ad into notion-dotnet:main Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants