fix: custom inspect should not throw when called with wrong this #61128
+17 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efekrskl force-pushed the fix/remove-eventtarget-custom-inspect-branding branch from 0530cf0 to 830ace5 Compare 
BridgeAR reviewed Dec 20, 2025
Comment on lines +15 to +17
| assert.doesNotThrow(() => { | ||
| util.inspect(fakeEventTarget); | ||
| }); |
Member
There was a problem hiding this comment.
Suggested change
| assert.doesNotThrow(() => { | |
| util.inspect(fakeEventTarget); | |
| }); | |
| util.inspect(fakeEventTarget); |
Using assert.doesNotThrow() is discouraged and is prohibited by the linter.
Ideally, we can verify the output as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #46323
I see
Eventhas a similar brand check (lib/internal/event_target.js:152) Should we also remove that one?