Skip to content

lib: enforce use of URLParse #61016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Dec 12, 2025
Merged

lib: enforce use of URLParse #61016

nodejs-github-bot merged 2 commits into from
Dec 12, 2025
+8 −4

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 10, 2025

There's no reason to use the user-mutable URL.parse in core.
@aduh95
lib: enforce use of URLParse
c7be984 
There's no reason to use the user-mutable `URL.parse` in core.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

Review requested:

  • @nodejs/test_runner
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. test_runner Issues and PRs related to the test runner subsystem. labels Dec 10, 2025
@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2025
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70475/
@codecov
Copy link

codecov bot commented Dec 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (83ba6b1) to head (aa8c4f3).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files 
@@ Coverage Diff @@ ## main #61016 +/- ## ========================================== + Coverage 88.51% 88.54% +0.02%  ========================================== Files 703 703 Lines 208432 208432 Branches 40200 40195 -5 ========================================== + Hits 184502 184548 +46  + Misses 15957 15905 -52  - Partials 7973 7979 +6
Files with missing lines Coverage Δ
lib/internal/socketaddress.js 98.98% <100.00%> (ø)
lib/internal/test_runner/mock/mock.js 98.72% <100.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70478/
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70480/
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2025
gurgunday
gurgunday approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 81e05e1 into nodejs:main Dec 12, 2025
70 of 72 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 12, 2025

Landed in 81e05e1
@aduh95 aduh95 deleted the URLParse branch December 12, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. test_runner Issues and PRs related to the test runner subsystem.