Skip to content

Conversation

@robinvw1
Copy link
Contributor

@robinvw1 robinvw1 commented Dec 9, 2025

Using globstar in glob pattern prevents dot (hidden) files from being matched

Fixes: #56321

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 9, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (17636f1) to head (b0b8df3).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/fs/glob.js 75.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #61012 +/- ## ========================================== - Coverage 88.53% 88.53% -0.01%  ========================================== Files 703 703 Lines 208448 208448 Branches 40207 40204 -3 ========================================== - Hits 184556 184544 -12  - Misses 15894 15915 +21  + Partials 7998 7989 -9 
Files with missing lines Coverage Δ
lib/internal/fs/glob.js 91.38% <75.00%> (-0.59%) ⬇️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@robinvw1 robinvw1 force-pushed the globstar-hidden-files branch from 7499588 to f0acade Compare December 10, 2025 11:01
Using globstar in glob pattern should not prevent dot (hidden) files from being matched.
@aduh95 aduh95 force-pushed the globstar-hidden-files branch from f0acade to b0b8df3 Compare December 10, 2025 12:22
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4db307a into nodejs:main Dec 11, 2025
74 of 77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4db307a

@robinvw1 robinvw1 deleted the globstar-hidden-files branch December 11, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

4 participants