lib,test: enforce use of assert.fail via a lint rule

[aduh95]

assert.fail communicates the intent better than assert(false) IMO

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (029ebac) to head (79df8b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@ ## main #61004 +/- ## ========================================== + Coverage 88.51% 88.55% +0.03%  ========================================== Files 703 703 Lines 208522 208522 Branches 40212 40219 +7 ========================================== + Hits 184564 184647 +83  + Misses 15957 15905 -52  + Partials 8001 7970 -31 

Files with missing lines	Coverage Δ
lib/internal/crypto/cipher.js	97.94% <100.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70448/

[Renegade334]

This pattern has actually made its way into lib as well (

node/lib/internal/crypto/cipher.js

Line 100 in 83ba6b1

assert(false, 'Cannot change encoding');

) – would it be better just to have it as a global rule?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70460/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70462/

[aduh95]

Landed in 79df8b2