Skip to content

Conversation

@sxa
Copy link
Member

@sxa sxa commented Dec 8, 2025

Another one in the set of tests marked flaky on AIX under #60565 - this is also exhibiting intermittent failing behaviour and is causing issues for PRs such as #60962 (comment) (which was on v24 so I'll backport to there once this is in)

Verifying it's level of flakiness in https://ci.nodejs.org/job/node-stress-single-test/628/ (Seems in the same ballpark as the others)

Screenshot from https://ci.nodejs.org/job/node-test-commit-aix/60068/nodes=aix72-ppc64/testReport/addons/tringbytes-external-exceed-max/ :
image

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa sxa self-assigned this Dec 8, 2025
@sxa sxa requested a review from joyeecheung December 8, 2025 17:09
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 8, 2025
@sxa sxa requested a review from richardlau December 8, 2025 17:09
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (40c57ed) to head (13e357e).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #60995 +/- ## ========================================== + Coverage 88.53% 88.54% +0.01%  ========================================== Files 703 703 Lines 208432 208432 Branches 40195 40196 +1 ========================================== + Hits 184526 184555 +29  + Misses 15925 15890 -35  - Partials 7981 7987 +6 

see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit e28656a into nodejs:main Dec 10, 2025
83 of 86 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e28656a

sxa added a commit to sxa/node that referenced this pull request Dec 11, 2025
Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: nodejs#60995 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sxa added a commit to sxa/node that referenced this pull request Dec 11, 2025
Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: nodejs#60995 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sxa added a commit to sxa/node that referenced this pull request Dec 11, 2025
Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: nodejs#60995 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sxa added a commit to sxa/node that referenced this pull request Dec 11, 2025
Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: nodejs#60995 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

4 participants