[v24.x][riscv] V8 backport to resolve compile failure #60989
Closed
+40 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Review requested:
|
nodejs-github-bot added needs-ci 
sxa added request-ci 
github-actions bot added request-ci-failed 
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/20026379622 |
9 tasks
Collaborator
Collaborator
sxa added request-ci github-actions bot added request-ci-failed Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/20029272474 |
Collaborator
Collaborator
Collaborator
Original commit message: [riscv] Fix the RISC-V build. Due to recent changes, there were missing implementations of various methods needed in the simulator and Maglev. Additionally, a static_cast is needed in the assembler to silence a warning. Port commit dfc894cd22d86ce42830e3bfdf485d963f6396ad Port commit c33af9bd408eadd6b62571f862bcb5b763c98ad9 Change-Id: Ie37a1cfa8225fc12f367ff62139cc7cd8fa967d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6396542 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#99706} Refs: v8/v8@1441665
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
richardlau approved these changes Dec 10, 2025
BethGriggs approved these changes Dec 11, 2025
richardlau pushed a commit that referenced this pull request Dec 11, 2025
Original commit message: [riscv] Fix the RISC-V build. Due to recent changes, there were missing implementations of various methods needed in the simulator and Maglev. Additionally, a static_cast is needed in the assembler to silence a warning. Port commit dfc894cd22d86ce42830e3bfdf485d963f6396ad Port commit c33af9bd408eadd6b62571f862bcb5b763c98ad9 Change-Id: Ie37a1cfa8225fc12f367ff62139cc7cd8fa967d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6396542 Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#99706} Refs: v8/v8@1441665 PR-URL: #60989 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Member
| Landed in d4dceb9. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Failure referenced in nodejs/build#4099 (comment) - the single line fix to
deps/v8/src/execution/riscv/simulator-riscv.his enough to allow the cross-compiled build to pass but it seems cleaner to to pull the full commit across. If any reviewers disagree then I'm happy to cut this down to just the single line.This will allow us to enable v24.x in the unofficial-builds repository.