-
- Notifications
You must be signed in to change notification settings - Fork 34.1k
deps: V8: cherry-pick 2abc61361dd4 #60177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+7 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original commit message: Fix scratch registers passed to mtvsrdd `ra` cannot be r0 as it will be interpreted as Operand(0) Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Junliang Yan <junyan1@ibm.com> Cr-Commit-Position: refs/heads/main@{#102388} Refs: v8/v8@2abc613
Collaborator
| Review requested:
|
cjihrig approved these changes Oct 9, 2025
Collaborator
Collaborator
Collaborator
Collaborator
targos approved these changes Oct 9, 2025
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
| Landed in a1b73fe |
9 tasks
richardlau added a commit that referenced this pull request Nov 7, 2025
Original commit message: Fix scratch registers passed to mtvsrdd `ra` cannot be r0 as it will be interpreted as Operand(0) Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Junliang Yan <junyan1@ibm.com> Cr-Commit-Position: refs/heads/main@{#102388} Refs: v8/v8@2abc613 PR-URL: #60177 Refs: nodejs/undici#4530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Nov 11, 2025
Original commit message: Fix scratch registers passed to mtvsrdd `ra` cannot be r0 as it will be interpreted as Operand(0) Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Junliang Yan <junyan1@ibm.com> Cr-Commit-Position: refs/heads/main@{#102388} Refs: v8/v8@2abc613 PR-URL: #60177 Refs: nodejs/undici#4530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. ppc Issues and PRs related to the Power architecture. v8 engine Issues and PRs related to the V8 dependency.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@2abc613
Refs: #59605 (comment)
Refs: nodejs/undici#4530
It turned out that nodejs/llparse#73 / undici 7.15.0 uncovered a bug on Power which has been addressed by this cherry-pick. It will unblock re-enabling SIMD in undici on Power (i.e. partially undoing nodejs/undici#4530).