src: avoid unnecessary string allocations in SPrintF impl #60052
+55 −22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In particular, this enables passing `std::string_view` instead.
If we can use a `std::string_view` instead of a `std::string`, let's just do that instead.
nodejs-github-bot added c++ 
addaleax changed the title 
jasnell approved these changes Sep 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #60052 +/- ## ========================================== + Coverage 88.45% 88.46% +0.01% ========================================== Files 703 703 Lines 207546 207549 +3 Branches 40011 40005 -6 ========================================== + Hits 183591 183615 +24 + Misses 15949 15906 -43 - Partials 8006 8028 +22
🚀 New features to boost your workflow:
|
addaleax added author ready 
github-actions bot removed the request-ci 
RafaelGSS approved these changes Sep 30, 2025
addaleax added a commit that referenced this pull request Sep 30, 2025
In particular, this enables passing `std::string_view` instead. PR-URL: #60052 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
addaleax added a commit that referenced this pull request Sep 30, 2025
If we can use a `std::string_view` instead of a `std::string`, let's just do that instead. PR-URL: #60052 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
| Landed in f304bc2...4a9a022 |
targos pushed a commit that referenced this pull request Oct 6, 2025
In particular, this enables passing `std::string_view` instead. PR-URL: #60052 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Oct 6, 2025
If we can use a `std::string_view` instead of a `std::string`, let's just do that instead. PR-URL: #60052 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
In particular, this enables passing `std::string_view` instead. PR-URL: #60052 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
If we can use a `std::string_view` instead of a `std::string`, let's just do that instead. PR-URL: #60052 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
src: make ToLower/ToUpper input args more flexible
In particular, this enables passing
std::string_viewinstead.src: avoid unnecessary string allocations in SPrintF impl
If we can use a
std::string_viewinstead of astd::string, let'sjust do that instead.