test: split indirect eval import tests #58637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Split indirect eval import tests as they depends on the JS stack to resolve the referrer.
nodejs-github-bot added esm 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #58637 +/- ## ========================================== - Coverage 90.15% 90.14% -0.01% ========================================== Files 636 636 Lines 187891 187891 Branches 36879 36879 ========================================== - Hits 169386 169372 -14 - Misses 11272 11282 +10 - Partials 7233 7237 +4 🚀 New features to boost your workflow:
|
JakobJingleheimer approved these changes Jun 9, 2025
github-actions bot removed the request-ci 
Collaborator
lpinca approved these changes Jun 9, 2025
Collaborator
JakobJingleheimer added commit-queue-squash 
legendecas added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in ccf105d |
targos pushed a commit that referenced this pull request Jun 16, 2025
Split indirect eval import tests as they depends on the JS stack to resolve the referrer. PR-URL: #58637 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jun 23, 2025
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
Split indirect eval import tests as they depends on the JS stack to resolve the referrer. PR-URL: #58637 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
Split indirect eval import tests as they depends on the JS stack to resolve the referrer. PR-URL: #58637 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Split indirect eval import tests as they depend on the JS stack to
resolve the referrer.
These tests can be wonky if the loader internals are changed and performs
microtasks with a JS stack (e.g. with
CallbackScope). In this case, thereferrer will be resolved to the top JS stack frame
node:internal/process/task_queues.js.This is due to the implementation detail of how V8 finds the referrer for a dynamic import
call.