Skip to content

Improve util getCallSites #57948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Improve util getCallSites #57948

wants to merge 2 commits into from

Conversation

@iwuliz
Copy link
Contributor

@iwuliz iwuliz commented Apr 20, 2025

This patch has two commits:

  1. Renamed test/fixtures/typescript/ts/test-get-callsite.ts and test/fixtures/typescript/ts/test-get-callsite-explicit.ts to test/fixtures/typescript/ts/test-get-callsites.ts and test/fixtures/typescript/ts/test-get-callsites-explicit.ts respectively, and update relevant occurrence, since the function getCallSite was renamed to getCallSites.
  2. Changed DCHECK TO CHECK to make the validation more robust.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 20, 2025

Review requested:

  • @nodejs/typescript
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 20, 2025
@codecov
Copy link

codecov bot commented Apr 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (7102ea1) to head (ba6676c).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/node_util.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@ Coverage Diff @@ ## main #57948 +/- ## ========================================== - Coverage 90.27% 90.27% -0.01%  ========================================== Files 630 630 Lines 186115 186116 +1 Branches 36467 36465 -2 ========================================== - Hits 168010 168009 -1  + Misses 10973 10969 -4  - Partials 7132 7138 +6
Files with missing lines Coverage Δ
src/node_util.cc 81.79% <0.00%> (-0.26%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66392/
@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 21, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 22, 2025

Landed in 6bf7fd7...367d593
nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2025
@iwuliz @nodejs-github-bot
test: rename to getCallSites
fba9c27 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2025
@iwuliz @nodejs-github-bot
src: change DCHECK to CHECK
367d593 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@iwuliz @RafaelGSS
test: rename to getCallSites
e2446ac 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@iwuliz @RafaelGSS
src: change DCHECK to CHECK
2216371 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@iwuliz @RafaelGSS
test: rename to getCallSites
21d052a 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@iwuliz @RafaelGSS
src: change DCHECK to CHECK
46062f1 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@iwuliz @aduh95
test: rename to getCallSites
062276f 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
a1935ba 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@iwuliz @aduh95
test: rename to getCallSites
615055a 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
4fb4c18 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@iwuliz @RafaelGSS
test: rename to getCallSites
8d0c061 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@iwuliz @RafaelGSS
src: change DCHECK to CHECK
dfca085 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@iwuliz @aduh95
test: rename to getCallSites
2e6e62b 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
4338e90 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@iwuliz @aduh95
test: rename to getCallSites
d8847d9 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
60d7f1c 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@iwuliz @aduh95
test: rename to getCallSites
265a450 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
f123439 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@iwuliz @aduh95
test: rename to getCallSites
6fa7144 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
5f25d3d 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@iwuliz @aduh95
test: rename to getCallSites
b7995e8 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
0eced6d 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@iwuliz @aduh95
test: rename to getCallSites
13f8f9c 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@iwuliz @aduh95
src: change DCHECK to CHECK
32b6e70 
PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

5 participants

@iwuliz @nodejs-github-bot @lpinca @marco-ippolito @jakecastelli