etw: fix descriptors of events 9 and 23 #5742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Member
| LGTM |
Member
| LGTM if CI is green: https://ci.nodejs.org/job/node-test-pull-request/1991/ |
Member
| @joaocgreis is this appropriate for v4? |
Member Author
Member
| @joaocgreis .. SGTM. After you land in v4.x-staging, please remove the lts-watch label and add the land-on-v4 label. Thank you! |
Contributor
| @joaocgreis can you hold off on landing on v4.x-staging until after the release of v4.4.1 (which should be tomorrow) |
joaocgreis added a commit that referenced this pull request Mar 23, 2016
Event 9 must include the string terminator in the last descriptor. Event 23 must be published with no descriptors, in accordance with the manifest. PR-URL: #5742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
joaocgreis added a commit to JaneaSystems/node that referenced this pull request Mar 23, 2016
Event 9 must include the string terminator in the last descriptor. Event 23 must be published with no descriptors, in accordance with the manifest. PR-URL: nodejs#5742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Member Author
| Landed on CI for |
Member
| Closed since it landed in master. Still need to get it landed in v4.x-staging tho. CI looks good. Failure there appears unrelated. |
Member Author
| Landed on Thanks! |
Contributor
| I have opted to back this out of Will re apply when it has time to mature in v5 |
Member
| +1 |
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
Event 9 must include the string terminator in the last descriptor. Event 23 must be published with no descriptors, in accordance with the manifest. PR-URL: #5742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
Event 9 must include the string terminator in the last descriptor. Event 23 must be published with no descriptors, in accordance with the manifest. PR-URL: #5742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 8, 2016
Event 9 must include the string terminator in the last descriptor. Event 23 must be published with no descriptors, in accordance with the manifest. PR-URL: #5742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
| This is now back in |
Merged
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Notable Changes: deps: - Fix `--gdbjit` for embedders. Backported from v8 upstream. (Ben Noordhuis) #5577 etw: - Correctly display descriptors for ETW events 9 and 23 on the windows platform. (João Reis) #5742 querystring: - Restore throw when attempting to stringify bad surrogate pair. (Brian White) #5858
MylesBorins pushed a commit that referenced this pull request Apr 12, 2016
Notable Changes: deps: - Fix `--gdbjit` for embedders. Backported from v8 upstream. (Ben Noordhuis) #5577 etw: - Correctly display descriptors for ETW events 9 and 23 on the windows platform. (João Reis) #5742 querystring: - Restore throw when attempting to stringify bad surrogate pair. (Brian White) #5858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
Affected core subsystem(s)
ETW
Description of change
A log of ETW events can be produced with:
The resulting
etlfile can be open in Event Viewer. However, ETW events 9 and 23 fail to display theEventData(under the Details tab), having instead aProcessingErrorDatasection with the data in raw hexadecimal. This happens because the events are not generated correctly.templateattribute), but is generated from node with a dummy integer descriptor, always equal to 0.There are two commits for easy review, I plan to squash and use the following commit message:
cc @nodejs/platform-windows