Skip to content

inspector: convert event params to protocol without json #57027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

inspector: convert event params to protocol without json #57027

merged 1 commit into from
Feb 24, 2025

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Feb 13, 2025

Event params object can be converted to inspector protocol directly.
This also enables binary data, like Network.dataReceived, to be sent
in the inspector protocol from JavaScript since JSON representation
does not support plain binary data.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 13, 2025
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Feb 13, 2025
@legendecas legendecas force-pushed the inspector/stringify branch 2 times, most recently from 88567de to 2c4f439 Compare February 13, 2025 11:55
@codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.62162% with 71 lines in your changes missing coverage. Please review.

Project coverage is 89.07%. Comparing base (85f5a6c) to head (cdd0230).
Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector/network_agent.cc 54.83% 32 Missing and 38 partials ⚠️
src/inspector_js_api.cc 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@ Coverage Diff @@ ## main #57027 +/- ## ========================================== - Coverage 89.11% 89.07% -0.04%  ========================================== Files 665 666 +1 Lines 193193 193282 +89 Branches 37212 37256 +44 ========================================== + Hits 172158 172167 +9  - Misses 13775 13815 +40  - Partials 7260 7300 +40
Files with missing lines Coverage Δ
lib/inspector.js 96.72% <100.00%> (+0.44%) ⬆️
src/inspector/network_inspector.cc 90.00% <100.00%> (ø)
src/inspector/network_inspector.h 100.00% <ø> (ø)
src/inspector/protocol_helper.h 100.00% <100.00%> (ø)
src/inspector_agent.cc 79.26% <100.00%> (+0.55%) ⬆️
src/inspector_agent.h 100.00% <ø> (ø)
src/inspector_js_api.cc 86.24% <83.33%> (-0.16%) ⬇️
src/inspector/network_agent.cc 61.65% <54.83%> (-33.54%) ⬇️

... and 25 files with indirect coverage changes
@legendecas
inspector: convert event params to protocol without json
cdd0230 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data.
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 14, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65198/
@legendecas
Copy link
Member Author

legendecas commented Feb 14, 2025

@nodejs/inspector would you mind taking a look at this? Thank you!
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65294/
@legendecas
Copy link
Member Author

legendecas commented Feb 19, 2025

@nodejs/inspector @nodejs/cpp-reviewers would you mind taking a look at this? Thank you!
@legendecas legendecas added the review wanted PRs that need reviews. label Feb 20, 2025
@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed review wanted PRs that need reviews. labels Feb 24, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit b7beb33 into nodejs:main Feb 24, 2025
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 24, 2025

Landed in b7beb33
@legendecas legendecas deleted the inspector/stringify branch February 24, 2025 13:22
targos pushed a commit that referenced this pull request Feb 25, 2025
@legendecas @targos
inspector: convert event params to protocol without json
347043d 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@legendecas @targos
inspector: convert event params to protocol without json
e10ef27 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@legendecas @RafaelGSS
inspector: convert event params to protocol without json
ba507d2 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@legendecas @RafaelGSS
inspector: convert event params to protocol without json
31a5ffb 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@legendecas @aduh95
inspector: convert event params to protocol without json
56b690e 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@legendecas @aduh95
inspector: convert event params to protocol without json
6fbbf06 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@legendecas @RafaelGSS
inspector: convert event params to protocol without json
f0959a4 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@legendecas @RafaelGSS
inspector: convert event params to protocol without json
1cf98a8 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@legendecas @RafaelGSS
inspector: convert event params to protocol without json
a5e1287 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@legendecas @RafaelGSS
inspector: convert event params to protocol without json
6fc0474 
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

3 participants

@legendecas @nodejs-github-bot @cola119