Skip to content

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Feb 7, 2025

PR-URL: #54897
Refs: #54295
Reviewed-By: Ethan Arrowood ethan@arrowood.dev
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com

cc @joyeecheung

PR-URL: nodejs#54897 Refs: nodejs#54295 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Feb 7, 2025
@joyeecheung
Copy link
Member

Thanks, do you plan to merge it soon?

@joyeecheung
Copy link
Member

Actually I think #54982 should probably also be there, though I can also just rebase on top of a bunch of REPLACEME (but they aren't really supposed to be picked up by the script in this release right?)

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Feb 7, 2025

Yeah that commit needs to get backported. I'll land this right after this release.

PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito added a commit that referenced this pull request Feb 10, 2025
PR-URL: #54897 Backport-PR-URL: #56948 Refs: #54295 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 10, 2025
PR-URL: #54982 Backport-PR-URL: #56948 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> PR-URL: #54897 Refs: #54295
@marco-ippolito
Copy link
Member Author

Landed in de5cbdc...697a392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

4 participants