2025-01-07, Version 23.6.0 (Current) #56450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: #56276 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
V8 should be built with -fvisibility=hidden, otherwise the resulting binary would contain unnecessary symbols. In particular, on macOS, this leads to 5000+ weak symbols resolved at runtime, leading to a startup regression. On macOS this also reduces the binary size about ~10MB. It's only enabled on macOS in this patch as gcc can time out or run out of memory on some machines in the CI with -fvisibility=hidden. PR-URL: #56275 Fixes: nodejs/performance#180 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56283 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56295 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #56282 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
When the source map data are invalid json strings, skip construct `SourceMap` on it. Additionally, suppress exceptions on source map lookups and fix test runners crash on invalid source maps. PR-URL: #56299 Refs: #56296 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Only invalidates source map lookup cache when a new source map is found. This improves when user codes interleave with builtin functions, like `array.map`. PR-URL: #56299 Refs: #56296 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
This commit stabilizes test isolation configuration in the test runner. PR-URL: #56298 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #56067 Fixes: #56014 Refs: whatwg/streams#1333 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #56162 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
We are in the process of updating macOS to version 13 in the Jenkins CI, but unfortunately this is taking longer than expected. Add it to the GitHub actions test matrix so that we have some coverage. Refs: nodejs/build#3686 PR-URL: #56307 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`btoa` only supports latin-1 charset and produces invalid source mapping urls. PR-URL: #56315 Refs: #56296 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56317 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #56318 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56300 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56325 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
PR-URL: #56332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #56334 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Migrate the eval tests in the `test/message` folder from Python to JS. PR-URL: #50482 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
co-authored-by: jazelly <xzha4350@gmail.com> PR-URL: #56278 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0. Increase the spin time on s390x only. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56228 Refs: #41286 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56285 Refs: nodejs/typescript#17 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #56341 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #55811 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
marco-ippolito force-pushed the v23.6.0-proposal branch from 3062e40 to 9fa6aeb Compare 
Contributor
| It will be magnificent ✨ to see 👀 #56274 in this release 🙄 |
Member
I see its a semver major change, so I don't know if it's possible to include it. @nodejs/releasers wdyt |
Contributor
As Richard said in #56274 (comment), Node.js follows a semver-compatible release process, and therefor semver-major PRs are only included in the next major release. Now there seems to be discussions in the PR thread on whether that update should be considered semver-major, so if the discussion settles on "it is not semver-major", it could be included in the next release, but it wouldn't make sense to delay this release until a consensus is found IMO. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## v23.x #56450 +/- ## ========================================== - Coverage 88.55% 88.55% -0.01% ========================================== Files 657 657 Lines 190225 190741 +516 Branches 36545 36622 +77 ========================================== + Hits 168458 168909 +451 - Misses 14954 15003 +49 - Partials 6813 6829 +16
|
github-actions bot removed the request-ci 
Collaborator
RafaelGSS approved these changes Jan 3, 2025
Member
| I see a babel failure in the CITGM (cc @nicolo-ribaudo): It seems the error changed |
| Will it be backported down to v22? |
Member
What commit? |
Member
Let's open an issue on https://github.com/nodejs/citgm to make sure we follow up with it. |
Member
Done nodejs/citgm#1087 |
all the good stuff related to |
Member
Yes that's the plan, its gonna take some time to make sure its safe to backport into an lts release line |
Member
| I see a signing error on the release CI @nodejs/build I'll retry it |
marco-ippolito pushed a commit that referenced this pull request Jan 7, 2025
Notable changes: lib: * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) #56359 module: * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) #56350 process: * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) #56400 worker: * (SEMVER-MINOR) add eval ts input (Marco Ippolito) #56394 PR-URL: #56450
marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request Jan 7, 2025
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Jan 7, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
Notable changes: lib: * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) nodejs#56359 module: * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) nodejs#56350 process: * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) nodejs#56400 worker: * (SEMVER-MINOR) add eval ts input (Marco Ippolito) nodejs#56394 PR-URL: nodejs#56450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2025-01-07, Version 23.6.0 (Current), @marco-ippolito
Notable Changes
Unflagging --experimental-strip-types
This release enables the flag
--experimental-strip-typesby default.Node.js will be able to execute TypeScript files without additional configuration:
There are some limitations in the supported syntax documented at https://nodejs.org/api/typescript.html#type-stripping
This feature is experimental and is subject to change.
Contributed by Marco Ippolito in #56350
Other Notable Changes
c1023284c3] - (SEMVER-MINOR) lib: add typescript support to STDIN eval (Marco Ippolito) #563598dc39e5e2e] - (SEMVER-MINOR) process: add process.ref() and process.unref() methods (James M Snell) #564008b20cc212b] - (SEMVER-MINOR) worker: add eval ts input (Marco Ippolito) #56394Commits
7b4d288116] - assert: make partialDeepStrictEqual throw when comparing [0] with [-0] (Giovanni) #562370ec2ed0a0b] - build: fix GN build for ngtcp2 (Cheng) #56300ab3e64630b] - build: test macos-13 on GitHub actions (Michaël Zasso) #5630746fb69daca] - build: build v8 with -fvisibility=hidden on macOS (Joyee Cheung) #562759d4930b993] - deps: update simdutf to 5.7.2 (Node.js GitHub Bot) #563886afe36397e] - deps: update amaro to 0.2.1 (Node.js GitHub Bot) #56390195990a0ee] - deps: update googletest to 7d76a23 (Node.js GitHub Bot) #56387b9c0852fc6] - deps: update googletest to e54519b (Node.js GitHub Bot) #56370eaefd90128] - deps: update ngtcp2 to 1.10.0 (Node.js GitHub Bot) #5633406de0c65cf] - deps: update simdutf to 5.7.0 (Node.js GitHub Bot) #5633203df76cdec] - doc: add example for piping ReadableStream (Gabriel Schulhof) #5641538ce249b07] - doc: expand description ofparseArg'sdefault(Kevin Gibbons) #54431ecc718cef2] - doc: use<ul>instead of<ol>inSECURITY.md(Antoine du Hamel) #563463db4809130] - doc: clarify that WASM is trusted (Matteo Collina) #56345384ccbacd5] - doc: update macOS and Xcode versions for releases (Michaël Zasso) #563373943986e88] - doc: fix thecrc32documentation (Kevin Toshihiro Uehara) #55898710b8fc6ed] - doc: add entry to changelog about SQLite Session Extension (Bart Louwers) #563184c978b4d77] - doc: fix links inmodule.md(Antoine du Hamel) #56283cdb631efe7] - esm: add experimental support for addon modules (Chengzhong Wu) #55844db83d2f0ee] - Revert "events: add hasEventListener util for validate" (origranot) #56282c2baae84ce] - lib: refactor execution.js (Marco Ippolito) #56358c1023284c3] - (SEMVER-MINOR) lib: add typescript support to STDIN eval (Marco Ippolito) #56359e4b795ec4a] - lib: optimizeprepareStackTraceon builtin frames (Chengzhong Wu) #56299d1b009b623] - lib: suppress source map lookup exceptions (Chengzhong Wu) #56299c2837f0805] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #5634272336233f2] - meta: move MoLow to TSC regular member (Moshe Atlow) #562764f77920a9d] - module: fix async resolution error within the syncfindPackageJSON(Jacob Smith) #56382e5ba216501] - (SEMVER-MINOR) module: unflag --experimental-strip-types (Marco Ippolito) #56350959f133a22] - module: support eval with ts syntax detection (Marco Ippolito) #56285717cfa4fac] - module: use buffer.toString base64 (Chengzhong Wu) #56315c2f4d8d688] - node-api: define version 10 (Gabriel Schulhof) #55676417a8ebdec] - node-api: remove deprecated attribute from napi_module_register (Vladimir Morozov) #561628dc39e5e2e] - (SEMVER-MINOR) process: add process.ref() and process.unref() methods (James M Snell) #56400d194f1ab5f] - sqlite: pass conflict type to conflict resolution handler (Bart Louwers) #5635229f5d70452] - src: use v8::LocalVector consistently with other minor cleanups (James M Snell) #564172a5543b78e] - src: use starts_with in fs_permission.cc (ishabi) #558113a3f5c9a64] - stream: validate undefined sizeAlgorithm in WritableStream (Jason Zhang) #560676e6f6b071a] - test: add ts eval snapshots (Marco Ippolito) #563588a87e39052] - test: remove empty lines from snapshots (Marco Ippolito) #56358510649f617] - test: use unusual chars in the path to ensure our tests are robust (Antoine du Hamel) #4840954f6d681a0] - test: remove flaky designation (Luigi Pinca) #5636920ace0bb01] - test: remove test-worker-arraybuffer-zerofill flaky designation (Luigi Pinca) #56364b757e40525] - test: remove test-net-write-fully-async-hex-string flaky designation (Luigi Pinca) #5636564556baddc] - test: improve abort signal dropping test (Edy Silva) #56339accbdad329] - test: enable ts test on win arm64 (Marco Ippolito) #563494188ee00d1] - test: deflake test-watch-file-shared-dependency (Luigi Pinca) #56344079cee0609] - test: skiptest-sqlite-extensionswhen SQLite is not built by us (Antoine du Hamel) #5634196a38044ee] - test: increase spin for eventloop test on s390 (Michael Dawson) #56228c062ffc242] - test: add coverage for pipeline (jakecastelli) #56278d4404f0d0e] - test: migrate message eval tests from Python to JS (Yiyun Lei) #504829369942745] - test: check typescript loader (Marco Ippolito) #546574930244484] - test: remove async-hooks/test-writewrap flaky designation (Luigi Pinca) #560487819bfec69] - test: deflake test-esm-loader-hooks-inspect-brk (Luigi Pinca) #56050e9762bf005] - test: add test case for listeners (origranot) #56282c1627e9d19] - test: maketest-permission-sqlite-load-extensionmore robust (Antoine du Hamel) #5629597d854e1d5] - test_runner,cli: mark test isolation as stable (Colin Ihrig) #56298a4f336fdd4] - tools: fixrequire-common-firstlint rule from subfolder (Antoine du Hamel) #56325dc3dafcb50] - tools: add release line label when opening release proposal (Antoine du Hamel) #563172a5ac932ac] - url: use resolved path to convert UNC paths to URL (Antoine du Hamel) #563028b20cc212b] - (SEMVER-MINOR) worker: add eval ts input (Marco Ippolito) #56394