Skip to content

os: improve path check with direct index access #55434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2024
Merged

os: improve path check with direct index access #55434

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d4011d
os: improve path check with direct index access
Oct 17, 2024
b7d37d3
used StringPrototypeSlice
Oct 17, 2024
b4039a3
Update os.js
mertcanaltin Oct 18, 2024
c62d231
Update os.js
mertcanaltin Oct 18, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const {
Float64Array,
NumberParseInt,
ObjectDefineProperties,
StringPrototypeEndsWith,
StringPrototypeSlice,
SymbolToPrimitive,
} = primordials;
Expand Down Expand Up @@ -184,9 +183,11 @@ function tmpdir() {
process.env.TMP ||
(process.env.SystemRoot || process.env.windir) + '\\temp';

if (path.length > 1 && StringPrototypeEndsWith(path, '\\') &&
!StringPrototypeEndsWith(path, ':\\'))
if (path.length > 1 && path[path.length - 1] === '\\' &&
!(path.length > 2 && path[path.length - 2] === ':' && path[path.length - 1] === '\\')) {
return StringPrototypeSlice(path, 0, -1);
}


return path;
}
Expand Down
Loading