test: ensure delay in recursive fs watch tests #51842
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them.
nodejs-github-bot added needs-ci 
Member Author
| Stress test on osx11-x64 (we don't have freebsd for stress tests it seems) https://ci.nodejs.org/view/Stress/job/node-stress-single-test/473/ |
github-actions bot removed the request-ci 
Collaborator
targos approved these changes Feb 23, 2024
Collaborator
Collaborator
aduh95 approved these changes Feb 23, 2024
lpinca approved these changes Feb 23, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions bot removed the request-ci Collaborator
aduh95 approved these changes Feb 23, 2024
Collaborator
Collaborator
Collaborator
joyeecheung added a commit that referenced this pull request Feb 25, 2024
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them. PR-URL: #51842 Refs: nodejs/reliability#790 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member Author
| It seems the bot had trouble relaying CI results to GitHub again. The last CI was yellow. Landed in 7f3852c. |
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them. PR-URL: #51842 Refs: nodejs/reliability#790 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them. PR-URL: #51842 Refs: nodejs/reliability#790 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them. PR-URL: #51842 Refs: nodejs/reliability#790 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them. PR-URL: #51842 Refs: nodejs/reliability#790 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them. PR-URL: #51842 Refs: nodejs/reliability#790 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them. PR-URL: nodejs#51842 Refs: nodejs/reliability#790 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
lpinca added a commit to lpinca/node that referenced this pull request Dec 23, 2024
Delay dependency file modification. Refs: nodejs#51842
lpinca added a commit to lpinca/node that referenced this pull request Dec 23, 2024
Delay dependency file modification on macOS. Refs: nodejs#51842
lpinca added a commit to lpinca/node that referenced this pull request Dec 23, 2024
Delay dependency file modification on macOS. Refs: nodejs#51842
lpinca added a commit to lpinca/node that referenced this pull request Dec 23, 2024
Delay dependency file modification on macOS. Refs: nodejs#51842
lpinca added a commit to lpinca/node that referenced this pull request Dec 23, 2024
Delay dependency file modification on macOS. Refs: nodejs#51842
lpinca added a commit to lpinca/node that referenced this pull request Dec 23, 2024
Delay dependency file modification on macOS. Refs: nodejs#51842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The recursive fs watch tests that mutate the watched folder immediately after fs.watch() returns are all flaking in the CI while the others that mutate the folder with a bit of delay aren't flaking. So this patch adds a bit of delay for the rest of the tests to deflake them.
Refs: nodejs/reliability#790