Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Jan 4, 2024

Main change that affects us: v8/v8@12203e0

Some flaky tests.
I would really appreciate help to investigate these. Node.js 22 is coming close!

12:33:52 not ok 3759 parallel/test-worker-arraybuffer-zerofill 12:33:52 --- 12:33:52 duration_ms: 120024.23700 12:33:52 severity: fail 12:33:52 exitcode: -15 12:33:52 stack: |- 12:33:52 timeout 12:33:52 ... 
12:40:34 not ok 3756 parallel/test-net-write-fully-async-hex-string 12:40:34 --- 12:40:34 duration_ms: 120066.81500 12:40:34 severity: fail 12:40:34 exitcode: -15 12:40:34 stack: |- 12:40:34 timeout 12:40:34 ... 
18:25:43 not ok 2444 parallel/test-shadow-realm-gc-module 18:25:43 --- 18:25:43 duration_ms: 6465.44100 18:25:43 severity: crashed 18:25:43 exitcode: -6 18:25:43 stack: |- 18:25:43 18:25:43 <--- Last few GCs ---> 18:25:43 .6[1674180:0x7f32cac7f000] 5861 ms: Mark-Compact 18.1 (48.4) -> 15.5 (49.2) MB, pooled: 0 MB, 5.89 / 0.01 ms (+ 16.5 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 26 ms) (average mu = 0.722, current mu = 0.7[1674180:0x7f32cac7f000] 6033 ms: Mark-Compact 22.4 (50.2) -> 18.8 (52.7) MB, pooled: 0 MB, 33.08 / 0.01 ms (+ 29.2 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 134 ms) (average mu = 0.666, current mu = 0 18:25:43 18:25:43 <--- JS stacktrace ---> 18:25:43 18:25:43 FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory 18:25:43 ----- Native stack trace ----- 18:25:43 18:25:43 ... 
18:46:01 not ok 2691 parallel/test-shadow-realm-gc 18:46:01 --- 18:46:01 duration_ms: 3138.09900 18:46:01 severity: crashed 18:46:01 exitcode: -11 18:46:01 stack: |- 
@targos targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Jan 4, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

@targos

This comment was marked as outdated.

@targos

This comment was marked as resolved.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@targos
Copy link
Member Author

targos commented Jan 7, 2024

/cc @nodejs/platform-windows @StefanStojanovic We're hitting nodejs/node-v8#271

@targos
Copy link
Member Author

targos commented Jan 7, 2024

Looks like the build is broken on AIX @nodejs/platform-aix

https://ci.nodejs.org/job/node-test-commit-aix/49875/nodes=aix72-ppc64/console

@targos
Copy link
Member Author

targos commented Jan 7, 2024

Many failing test on s390: https://ci.nodejs.org/job/node-test-commit-linuxone/41750/#showFailuresLink

@nodejs/platform-s390

@targos
Copy link
Member Author

targos commented Jan 8, 2024

@nodejs/platform-smartos The SmartOS build is broken (related to d1ccf72): https://ci.nodejs.org/job/node-test-commit-smartos/52823/nodes=smartos20-64/console

@targos
Copy link
Member Author

targos commented Jan 8, 2024

@nodejs/platform-ppc @nodejs/platform-s390 The V8 CI build errors:

16:08:40 g++: fatal error: Killed signal terminated program cc1plus 

https://ci.nodejs.org/job/node-test-commit-v8-linux/5757/nodes=rhel8-ppc64le,v8test=v8test/console
https://ci.nodejs.org/job/node-test-commit-v8-linux/5757/nodes=rhel8-s390x,v8test=v8test/console

@targos
Copy link
Member Author

targos commented Jan 8, 2024

It looks like 9570832 is not enough. There's a flaky test in debug mode:

./node_g test/sequential/test-worker-fshandles-error-on-termination.js
$ ./node_g test/sequential/test-worker-fshandles-error-on-termination.js # # Fatal error in ../../deps/v8/src/execution/isolate-inl.h, line 105 # Debug check failed: has_exception() == result == ReadOnlyRoots(this).exception() (1 vs. 0). # # # #FailureMessage Object: 0x16f6ed148 ----- Native stack trace ----- 1: 0x1048b5400 node::DumpNativeBacktrace(__sFILE*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 2: 0x104afddd4 node::NodePlatform::GetStackTracePrinter()::$_3::operator()() const [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 3: 0x104afdd90 node::NodePlatform::GetStackTracePrinter()::$_3::__invoke() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 4: 0x106c702f0 V8_Fatal(char const*, int, char const*, ...) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 5: 0x106c6fe8c std::__1::enable_if<!std::is_function<std::__1::remove_pointer<char>::type>::value && !std::is_enum<char>::value && has_output_operator<char, v8::base::CheckMessageStream>::value, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>::type v8::base::PrintCheckOperand<char>(char) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 6: 0x104ebb208 v8::internal::Isolate::VerifyBuiltinsResult(v8::internal::Tagged<v8::internal::Object>) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 7: 0x105a4943c v8::internal::Runtime_PromiseRejectEventFromStack(int, unsigned long*, v8::internal::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 8: 0x10615e7b4 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 9: 0x1061edabc Builtins_PromiseReject [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 10: 0x1060bc370 Builtins_InterpreterEntryTrampoline [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 11: 0x1061f9420 Builtins_PromiseRejectReactionJob [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 12: 0x1060eb2ec Builtins_RunMicrotasks [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 13: 0x1060b96f4 Builtins_JSRunMicrotasksEntry [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 14: 0x105131e9c v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 15: 0x105133870 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 16: 0x105133f20 v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 17: 0x105186dec v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 18: 0x105186b0c v8::internal::MicrotaskQueue::PerformCheckpointInternal(v8::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 19: 0x1047f7110 node::InternalCallbackScope::Close() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 20: 0x1047f6f2c node::InternalCallbackScope::~InternalCallbackScope() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 21: 0x1047f6a3c node::InternalCallbackScope::~InternalCallbackScope() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 22: 0x1049ec984 node::fs::FSReqPromise<node::AliasedBufferBase<double, v8::Float64Array>>::Reject(v8::Local<v8::Value>) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 23: 0x104a061fc node::fs::FSReqAfterScope::Reject(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 24: 0x104a06324 node::fs::FSReqAfterScope::Proceed() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 25: 0x104a06be0 node::fs::AfterOpenFileHandle(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 26: 0x1049ee5bc node::MakeLibuvRequestCallback<uv_fs_s, void (*)(uv_fs_s*)>::Wrapper(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 27: 0x10608c3c4 uv__fs_done [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 28: 0x10607e4ec uv__work_done [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 29: 0x1060874d0 uv__async_io [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 30: 0x1060aaea0 uv__io_poll [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 31: 0x106087ed0 uv_run [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 32: 0x1047fa37c node::SpinEventLoopInternal(node::Environment*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 33: 0x104ba3c34 node::worker::Worker::Run() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 34: 0x104ba7cb8 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::operator()(void*) const [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 35: 0x104ba7c64 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node] 36: 0x1843de034 _pthread_start [/usr/lib/system/libsystem_pthread.dylib] 37: 0x1843d8e3c thread_start [/usr/lib/system/libsystem_pthread.dylib] [1] 34458 trace trap ./node_g test/sequential/test-worker-fshandles-error-on-termination.js 
@StefanStojanovic
Copy link
Contributor

/cc @nodejs/platform-windows @StefanStojanovic We're hitting nodejs/node-v8#271

Thanks for letting me know. I just got back to work today, so will look into it in the following days.

@sumitradawn
Copy link

Looks like the build is broken on AIX @nodejs/platform-aix

https://ci.nodejs.org/job/node-test-commit-aix/49875/nodes=aix72-ppc64/console

I have checked and the v8 build is fine for AIX wrt current commit id- ff9dc695ffc0412baf644e4cddfa92b93cd2b978 (HEAD, origin/main, origin/HEAD)

Screenshot 2024-01-08 at 7 51 16 PM
@targos
Copy link
Member Author

targos commented Jan 8, 2024

@sumitradawn This is not with V8 HEAD. It's with 12.1-lkgr

@sumitradawn
Copy link

@sumitradawn This is not with V8 HEAD. It's with 12.1-lkgr

@targos I have tried to build Node from the source code on AIX and it is quite fine for me. There might be some memory issue, Can you please try to run the job with -j4 option.

codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
jkleinsc pushed a commit to electron/electron that referenced this pull request Nov 4, 2024
* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolve nodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 22, 2025
Otherwise re-entering V8 doesn't work as expected after exceptions were thrown. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5050065 Co-Authored-By: Toon Verwaest <verwaest@chromium.org> Co-Authored-By: deepak1556 <hop2deep@gmail.com> PR-URL: nodejs#51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
Otherwise re-entering V8 doesn't work as expected after exceptions were thrown. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5050065 Co-Authored-By: Toon Verwaest <verwaest@chromium.org> Co-Authored-By: deepak1556 <hop2deep@gmail.com> PR-URL: nodejs#51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
Otherwise re-entering V8 doesn't work as expected after exceptions were thrown. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5050065 Co-Authored-By: Toon Verwaest <verwaest@chromium.org> Co-Authored-By: deepak1556 <hop2deep@gmail.com> PR-URL: nodejs#51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.