bootstrap: improve snapshot unsupported builtin warnings #50944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
joyeecheung commented Nov 27, 2023
joyeecheung commented - Only emit warning when the snapshot is built. In general built-ins loaded after the snapshot is built should work as usual.
- Clarify what the warning means
- Only emit warning when the snapshot is built. In general built-ins loaded after the snapshot is built should work as usual. - Clarify what the warning means
H4ad approved these changes Nov 28, 2023
H4ad added author ready 
github-actions bot removed the request-ci 
Collaborator
Collaborator
Collaborator
legendecas reviewed Nov 29, 2023
aduh95 approved these changes Nov 29, 2023
lpinca approved these changes Dec 1, 2023
joyeecheung commented Dec 3, 2023
github-actions bot removed the request-ci Collaborator
github-actions bot removed the request-ci Collaborator
jasnell approved these changes Dec 9, 2023
Collaborator
lpinca added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
| Landed in 390061e |
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
- Only emit warning when the snapshot is built. In general built-ins loaded after the snapshot is built should work as usual. - Clarify what the warning means PR-URL: #50944 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
- Only emit warning when the snapshot is built. In general built-ins loaded after the snapshot is built should work as usual. - Clarify what the warning means PR-URL: #50944 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.