-
- Notifications
You must be signed in to change notification settings - Fork 33.8k
test: set test-worker-nearheaplimit-deadlock flaky #50238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot merged 1 commit into nodejs:main from JaneaSystems:mefi-test-worker-nearheaplimit-deadlock-flaky Oct 18, 2023
Merged
test: set test-worker-nearheaplimit-deadlock flaky #50238
nodejs-github-bot merged 1 commit into nodejs:main from JaneaSystems:mefi-test-worker-nearheaplimit-deadlock-flaky Oct 18, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test is only flaky on x86 Windows. Fixes: nodejs#50220
Contributor
| Fast-track has been requested by @anonrig. Please 👍 to approve. |
Collaborator
richardlau approved these changes Oct 18, 2023
anonrig approved these changes Oct 18, 2023
H4ad approved these changes Oct 18, 2023
Collaborator
mhdawson approved these changes Oct 18, 2023
Member
mhdawson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Collaborator
| Landed in dbd0ffa |
25 tasks
This was referenced Oct 19, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
The test is only flaky on x86 Windows. Fixes: nodejs#50220 PR-URL: nodejs#50238 Refs: nodejs#49962 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
The test is only flaky on x86 Windows. Fixes: nodejs/node#50220 PR-URL: nodejs/node#50238 Refs: nodejs/node#49962 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
The test is only flaky on x86 Windows. Fixes: nodejs/node#50220 PR-URL: nodejs/node#50238 Refs: nodejs/node#49962 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The test is only flaky on x86 Windows.
Refs: #49962
Fixes: #50220