Revert "test: mark test-runner-output as flaky" #49905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 717e233. Refs: nodejs@fef7927cc3a7
nodejs-github-bot added needs-ci 
cjihrig approved these changes Sep 27, 2023
MoLow approved these changes Sep 27, 2023
aduh95 added author ready nodejs-github-bot added commit-queue-failed 
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49905 ✔ Done loading data for nodejs/node/pull/49905 ----------------------------------- PR info ------------------------------------ Title Revert "test: mark test-runner-output as flaky" (#49905) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:revert/717e233cd956 -> nodejs:main Labels test, author ready Commits 1 - Revert "test: mark test-runner-output as flaky" Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/49905 Refs: https://github.com/nodejs/node/commit/fef7927cc3a7 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49905 Refs: https://github.com/nodejs/node/commit/fef7927cc3a7 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 27 Sep 2023 17:41:11 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/49905#pullrequestreview-1647260204 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49905#pullrequestreview-1647379240 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6355169313 |
github-actions bot removed the request-ci Collaborator
31 tasks
Collaborator
Collaborator
lpinca added commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in f05d6d0 |
16 tasks
GeoffreyBooth pushed a commit to GeoffreyBooth/node that referenced this pull request Oct 1, 2023
This reverts commit 717e233. Refs: nodejs@fef7927cc3a7 PR-URL: nodejs#49905 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Oct 2, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
This reverts commit 717e233. Refs: nodejs@fef7927cc3a7 PR-URL: nodejs#49905 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
This reverts commit 717e233. Refs: fef7927cc3a7 PR-URL: #49905 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
This reverts commit 717e233. Refs: nodejs@fef7927cc3a7 PR-URL: nodejs#49905 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This reverts commit 717e233.
Refs: fef7927cc3a7