doc: add missing deprecated blocks to cluster #47981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I believe that these are required so that the respective APIs are marked as deprecated in the table of contents.
nodejs-github-bot added cluster 
Mesteery approved these changes May 13, 2023
tniessen added the author ready 
VoltrexKeyva approved these changes May 13, 2023
tniessen added the commit-queue 
deokjinkim approved these changes May 14, 2023
deokjinkim added a commit to deokjinkim/node that referenced this pull request May 14, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark and test. Refs: nodejs#47981
deokjinkim added a commit to deokjinkim/node that referenced this pull request May 14, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: nodejs#47981
nodejs-github-bot removed the commit-queue 
Collaborator
| Landed in c9ec72d |
targos pushed a commit that referenced this pull request May 15, 2023
I believe that these are required so that the respective APIs are marked as deprecated in the table of contents. PR-URL: #47981 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Member Author
This turned out to be true :) |
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
I believe that these are required so that the respective APIs are marked as deprecated in the table of contents. PR-URL: #47981 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
I believe that these are required so that the respective APIs are marked as deprecated in the table of contents. PR-URL: nodejs#47981 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: nodejs#47981 PR-URL: nodejs#48002 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I believe that these are required so that the respective APIs are marked as deprecated in the table of contents.