Skip to content

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Apr 26, 2023

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 26, 2023
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 26, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47725 ✔ Done loading data for nodejs/node/pull/47725 ----------------------------------- PR info ------------------------------------ Title tools: fix update-v8-patch cache (#47725) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix/v8-cache-update -> nodejs:main Labels meta, fast-track Commits 1 - tools: fix update-v8-patch cache Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47725 Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47725 Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 26 Apr 2023 10:37:55 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47725#pullrequestreview-1401760300 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47725#pullrequestreview-1401964994 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47725 From https://github.com/nodejs/node * branch refs/pull/47725/merge -> FETCH_HEAD ✔ Fetched commits as 76044c4e2b6a..289210191123 -------------------------------------------------------------------------------- [main 3cc155d32e] tools: fix update-v8-patch cache Author: Marco Ippolito Date: Wed Apr 26 12:36:51 2023 +0200 1 file changed, 6 insertions(+), 2 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- tools: fix update-v8-patch cache 

PR-URL: #47725
Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Michaël Zasso targos@protonmail.com

[main bb52f5ba59] tools: fix update-v8-patch cache
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Wed Apr 26 12:36:51 2023 +0200
1 file changed, 6 insertions(+), 2 deletions(-)
✖ bb52f5ba59b5c0a6d84d3a05815ae907d172b20f
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✖ 2:7 Fixes must be a GitHub URL. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/4809328695

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit ad5a0d1 into nodejs:main Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ad5a0d1

yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

4 participants