-
- Notifications
You must be signed in to change notification settings - Fork 33.7k
tools: fix update-v8-patch cache #47725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot merged 1 commit into nodejs:main from marco-ippolito:fix/v8-cache-update Apr 26, 2023
Merged
tools: fix update-v8-patch cache #47725
nodejs-github-bot merged 1 commit into nodejs:main from marco-ippolito:fix/v8-cache-update Apr 26, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Review requested:
|
c44aa24 to 2892101 Compare richardlau approved these changes Apr 26, 2023
targos approved these changes Apr 26, 2023
Contributor
| Fast-track has been requested by @targos. Please 👍 to approve. |
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47725 ✔ Done loading data for nodejs/node/pull/47725 ----------------------------------- PR info ------------------------------------ Title tools: fix update-v8-patch cache (#47725) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix/v8-cache-update -> nodejs:main Labels meta, fast-track Commits 1 - tools: fix update-v8-patch cache Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47725 Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47725 Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 26 Apr 2023 10:37:55 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47725#pullrequestreview-1401760300 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47725#pullrequestreview-1401964994 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47725 From https://github.com/nodejs/node * branch refs/pull/47725/merge -> FETCH_HEAD ✔ Fetched commits as 76044c4e2b6a..289210191123 -------------------------------------------------------------------------------- [main 3cc155d32e] tools: fix update-v8-patch cache Author: Marco Ippolito Date: Wed Apr 26 12:36:51 2023 +0200 1 file changed, 6 insertions(+), 2 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- tools: fix update-v8-patch cachehttps://github.com/nodejs/node/actions/runs/4809328695 |
Collaborator
| Landed in ad5a0d1 |
Member
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692