build: refactor configure.py #47667
Merged
build: refactor configure.py #47667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
VoltrexKeyva force-pushed the refactor-conf branch 2 times, most recently from ea8a68c to bd7104c Compare VoltrexKeyva added the python 
Member Author
| @nodejs/python |
cclauss requested changes Apr 22, 2023
- Explicitly specify the encoding when opening files. - Use f-strings to format strings. - Use `isinstance()` for type checks instead of `type()`. - Use the `with` keyword for resource-allocating operations. - Avoid using multiple statements in a single line. - Remove unnecessary `else` clauses after `return`. - Iterate with the `items()` method of dictionaries when both the key and value are used. - Remove unnecessary parentheses. - Rename unused unpacked variables to `_`, `_1`, etc etc. - Rename the `list` variable to avoid conflict with the global `list()` function.
VoltrexKeyva force-pushed the refactor-conf branch from bd7104c to 3473151 Compare cclauss approved these changes Apr 22, 2023
github-actions bot removed the request-ci 
Collaborator
VoltrexKeyva added commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in a4cf6b2 |
targos pushed a commit that referenced this pull request May 2, 2023
- Explicitly specify the encoding when opening files. - Use f-strings to format strings. - Use `isinstance()` for type checks instead of `type()`. - Use the `with` keyword for resource-allocating operations. - Avoid using multiple statements in a single line. - Remove unnecessary `else` clauses after `return`. - Iterate with the `items()` method of dictionaries when both the key and value are used. - Remove unnecessary parentheses. - Rename unused unpacked variables to `_`, `_1`, etc etc. - Rename the `list` variable to avoid conflict with the global `list()` function. PR-URL: #47667 Reviewed-By: Christian Clauss <cclauss@me.com>
targos pushed a commit that referenced this pull request May 3, 2023
- Explicitly specify the encoding when opening files. - Use f-strings to format strings. - Use `isinstance()` for type checks instead of `type()`. - Use the `with` keyword for resource-allocating operations. - Avoid using multiple statements in a single line. - Remove unnecessary `else` clauses after `return`. - Iterate with the `items()` method of dictionaries when both the key and value are used. - Remove unnecessary parentheses. - Rename unused unpacked variables to `_`, `_1`, etc etc. - Rename the `list` variable to avoid conflict with the global `list()` function. PR-URL: #47667 Reviewed-By: Christian Clauss <cclauss@me.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
- Explicitly specify the encoding when opening files. - Use f-strings to format strings. - Use `isinstance()` for type checks instead of `type()`. - Use the `with` keyword for resource-allocating operations. - Avoid using multiple statements in a single line. - Remove unnecessary `else` clauses after `return`. - Iterate with the `items()` method of dictionaries when both the key and value are used. - Remove unnecessary parentheses. - Rename unused unpacked variables to `_`, `_1`, etc etc. - Rename the `list` variable to avoid conflict with the global `list()` function. PR-URL: #47667 Reviewed-By: Christian Clauss <cclauss@me.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
- Explicitly specify the encoding when opening files. - Use f-strings to format strings. - Use `isinstance()` for type checks instead of `type()`. - Use the `with` keyword for resource-allocating operations. - Avoid using multiple statements in a single line. - Remove unnecessary `else` clauses after `return`. - Iterate with the `items()` method of dictionaries when both the key and value are used. - Remove unnecessary parentheses. - Rename unused unpacked variables to `_`, `_1`, etc etc. - Rename the `list` variable to avoid conflict with the global `list()` function. PR-URL: nodejs#47667 Reviewed-By: Christian Clauss <cclauss@me.com>
richardlau added a commit to richardlau/node-1 that referenced this pull request Feb 7, 2024
The warning message was inadvertently changed to a newer version of g++ than the one being checked for when a refactor PR was merged to v18.x-staging. Refs: nodejs#47667
richardlau added a commit to richardlau/node-1 that referenced this pull request Feb 15, 2024
The warning message was inadvertently changed to a newer version of g++ than the one being checked for when a refactor PR was merged to v18.x-staging. Refs: nodejs#47667
richardlau added a commit that referenced this pull request Feb 28, 2024
The warning message was inadvertently changed to a newer version of g++ than the one being checked for when a refactor PR was merged to v18.x-staging. Refs: #47667 PR-URL: #51695 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
isinstance()for type checks instead oftype().withkeyword for resource-allocating operations.elseclauses afterreturn.items()method of dictionaries when both the key and value are used._,_1, etc etc.listvariable to avoid conflict with the globallist()function.Refs: #47581 (comment)