-
- Notifications
You must be signed in to change notification settings - Fork 33.7k
doc: create maintaining folder for deps #47589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: create maintaining folder for deps #47589
Conversation
9faad4b to d10d022 Compare | SGTM |
tniessen left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these files seem like they could be very short now that most is automated (and we don't want manual updates in most cases), maybe we could even put everything into a single document or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does not really match the common theme since only a small part of it is about updating uvwasi.
| probably there is no longer the need to describe the updating procedure because for most of them is automated and there is just one script thus making some |
05b4919 to 19d33fe Compare | I think we should keep them in multiple files once the automation doesn't handle other active release lines. For instance, OpenSSL 1.x on v14 or OpenSSL 1.x+quic on v16 versions. Also, I'm not sure about removing the |
| OpenSSL has its own |
19d33fe to 7ada588 Compare 7ada588 to 6a56cca Compare 6a56cca to cab0fa8 Compare Commit Queue failed- Loading data for nodejs/node/pull/47589 ✔ Done loading data for nodejs/node/pull/47589 ----------------------------------- PR info ------------------------------------ Title doc: create maintaining folder for deps (#47589) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/organize-maintaining -> nodejs:main Labels doc, author ready Commits 1 - doc: create maintaining folder for deps Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47589 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47589 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: create maintaining folder for deps ℹ This PR was created on Mon, 17 Apr 2023 09:09:21 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1394928517 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47589#pullrequestreview-1395787388 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1396007103 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4806355194 |
Commit Queue failed- Loading data for nodejs/node/pull/47589 ✔ Done loading data for nodejs/node/pull/47589 ----------------------------------- PR info ------------------------------------ Title doc: create maintaining folder for deps (#47589) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/organize-maintaining -> nodejs:main Labels doc, author ready Commits 1 - doc: create maintaining folder for deps Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47589 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47589 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: James M Snell Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 17 Apr 2023 09:09:21 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1394928517 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47589#pullrequestreview-1395787388 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47589#pullrequestreview-1402037281 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4809803241 |
5686e44 to 980fd28 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| Landed in 109ab0a |
PR-URL: #47589 Refs: nodejs/security-wg#828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #47589 Refs: nodejs/security-wg#828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #47589 Refs: nodejs/security-wg#828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#47589 Refs: nodejs/security-wg#828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
I would like to receive some feedback on this idea.
I wanted to move all the
maintaining-xfiles under a common folder and I have created an overview file that lists all the dependencies and in a second iteration their version that will be updated by thetools.ymlaction.Should we keep the name of the md files
maintaing-xor justx?@nodejs/security-wg
Refs: nodejs/security-wg#828