esm: fix import assertion warning #46971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aduh95 added experimental 
Collaborator
| Review requested:
|
Contributor
| Fast-track has been requested by @aduh95. Please 👍 to approve. |
nodejs-github-bot added esm 
debadree25 approved these changes Mar 6, 2023
MoLow approved these changes Mar 6, 2023
JakobJingleheimer approved these changes Mar 6, 2023
aymen94 approved these changes Mar 6, 2023
GeoffreyBooth approved these changes Mar 6, 2023
ljharb approved these changes Mar 6, 2023
lpinca approved these changes Mar 6, 2023
aduh95 added author ready 
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
Contributor Author
19 tasks
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in 0c4f8f2 |
This was referenced Mar 8, 2023
This was referenced Mar 10, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
Refs: #46901 (comment) PR-URL: #46971 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
Refs: #46901 (comment) PR-URL: #46971 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
Refs: #46901 (comment) PR-URL: #46971 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refs: #46901 (comment)