test: remove OpenSSL 1.0.2 error message compat #46709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tniessen added tls 
richardlau approved these changes Feb 18, 2023
github-actions bot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
panva added the author ready 
panva approved these changes Feb 18, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
lpinca approved these changes Feb 18, 2023
21 tasks
Member Author
| CI passed (according to Jenkins) but the GitHub UI has not picked that up. I don't know if that's gonna prevent the commit queue from landing this. |
24 tasks
jasnell approved these changes Feb 20, 2023
tniessen added the commit-queue Collaborator
While upgrading from OpenSSL 1.0.2 to 1.1.1, these tests were modified to recognize error messages from both OpenSSL releases. Given that OpenSSL 1.0.2 has been unsupported for years, it is safe to remove the older message patterns. Refs: nodejs#16130
tniessen force-pushed the test-ossl102-error-messages branch from d421d7d to b4bbddb Compare tniessen added request-ci Member Author
| Force-pushed without changes, hoping to unbreak Jenkins status in the GitHub UI and thus the commit queue. |
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
34 tasks
panva approved these changes Feb 22, 2023
panva added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
| Landed in bc58a85 |
31 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
While upgrading from OpenSSL 1.0.2 to 1.1.1, these tests were modified to recognize error messages from both OpenSSL releases. Given that OpenSSL 1.0.2 has been unsupported for years, it is safe to remove the older message patterns. Refs: #16130 PR-URL: #46709 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
While upgrading from OpenSSL 1.0.2 to 1.1.1, these tests were modified to recognize error messages from both OpenSSL releases. Given that OpenSSL 1.0.2 has been unsupported for years, it is safe to remove the older message patterns. Refs: #16130 PR-URL: #46709 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While upgrading from OpenSSL 1.0.2 to 1.1.1, these tests were modified to recognize error messages from both OpenSSL releases. Given that OpenSSL 1.0.2 has been unsupported for years, it is safe to remove the older message patterns.
Refs: #16130