[v18.x backport] crypto: add CryptoKey Symbol.toStringTag #46340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Review requested:
|
nodejs-github-bot added crypto panva added a commit to panva/node that referenced this pull request Jan 24, 2023
closes nodejs#45987 PR-URL: nodejs#46042 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Backport-PR-URL: nodejs#46340
panva force-pushed the backport-46042-to-v18.x branch from 14d0106 to 043d264 Compare panva added a commit to panva/node that referenced this pull request Jan 24, 2023
closes nodejs#45987 PR-URL: nodejs#46042 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Backport-PR-URL: nodejs#46340
panva force-pushed the backport-46042-to-v18.x branch from 043d264 to e6e9a79 Compare 
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
Member Author
| cc @juanarbol |
12 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member Author
| It appears you've got this in v18.x-staging already. 👍 feel free to close as needed. |
Member
| I will rebase and rerun the CI for this backport! Thanks so much for backporting this! <3 |
Member Author
| It'll end up being an empty commit, you've already got the pr landed on staging (somehow ;)) |
closes nodejs#45987 PR-URL: nodejs#46042 Backport-PR-URL: nodejs#46340 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol force-pushed the backport-46042-to-v18.x branch from e6e9a79 to 1a3cd21 Compare This comment was marked as outdated.
This comment was marked as outdated.
Member
A, yeah, that makes sense. I usually try land PRs even with merge conflicts; just after merge conflicts (resolved) break some tests, I request the backports to the authors. Anyway thanks for backporting this! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backports #46042 because it doesn't land cleanly without #45855 but is in itself useful to backport for the ecosystem given the longevity of the v18.x LTS release line.