doc: update isUtf8 description #45973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added buffer 
addaleax reviewed Dec 26, 2022
tniessen approved these changes Dec 30, 2022
anonrig added the author ready 
targos approved these changes Jan 1, 2023
anonrig added the commit-queue nodejs-github-bot added commit-queue-failed 
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45973 FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close at consumeBody (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Response.text (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18) at async Request.json (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18) at async Request.query (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20) at async Request.queryAll (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20) at async Request.gql (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22) at async PRData.getComments (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21) at async Promise.all (index 2) at async Promise.all (index 1) { type: 'system', errno: 'ERR_STREAM_PREMATURE_CLOSE', code: 'ERR_STREAM_PREMATURE_CLOSE', erroredSysCall: undefined }https://github.com/nodejs/node/actions/runs/3817570885 |
aduh95 added commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in 5ba1717 |
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2023
PR-URL: #45973 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45973 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45973 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #45973 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
PR-URL: #45973 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Addresses @lpinca and @jasnell's comments on
buffer.isUtf8