tools: add release host var to promotion script #45913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Review requested:
|
mscdex reviewed Dec 19, 2022
ruyadorno force-pushed the add-host-env-var-to-release-script branch 2 times, most recently from 8d30d64 to 4fcdf24 Compare 
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
RafaelGSS approved these changes Dec 20, 2022
Collaborator
lpinca reviewed Dec 20, 2022
jasnell approved these changes Dec 20, 2022
12 tasks
aymen94 approved these changes Dec 21, 2022
14 tasks
RafaelGSS added the author ready 13 tasks
aduh95 reviewed Dec 28, 2022
aymen94 approved these changes Dec 28, 2022
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com>
ruyadorno force-pushed the add-host-env-var-to-release-script branch from 4fcdf24 to 9ce6067 Compare Collaborator
aduh95 approved these changes Jan 1, 2023
aduh95 added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
| Landed in 361d34c |
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2023
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a
NODEJS_RELEASE_HOSTenvironment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release.cc @nodejs/releasers