[v16.x] src: add support for externally shared js builtins #45867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Refs: nodejs#44000 - add infra to support externally shared js builtins in support of distos that want to externalize deps that include JS/WASM instead of native code - add support for externalizing - cjs_module_lexer/lexer - cjs_module_lexer/dist/lexer - undici/undici Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#44376 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Collaborator
| Review requested:
|
nodejs-github-bot added lib / src 
github-actions bot removed the request-ci Collaborator
Member
| cc @guybedford |
legendecas changed the title This was referenced Dec 17, 2022
github-actions bot removed the request-ci Collaborator
21 tasks
github-actions bot removed the request-ci Collaborator
Collaborator
This was referenced Feb 20, 2023
BethGriggs approved these changes Mar 22, 2023
BethGriggs pushed a commit that referenced this pull request Mar 23, 2023
Refs: #44000 - add infra to support externally shared js builtins in support of distos that want to externalize deps that include JS/WASM instead of native code - add support for externalizing - cjs_module_lexer/lexer - cjs_module_lexer/dist/lexer - undici/undici Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44376 Backport-PR-URL: #45867 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
| Landed in 6a01d39 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refs: #44000
Signed-off-by: Michael Dawson mdawson@devrus.com
PR-URL: #44376
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com