test: fix flaky test-perf-hooks-histogram #43567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Make sure the histogram containing event loop delay info is posted only when at least one datapoint is collected. Fixes: nodejs#43503
nodejs-github-bot added needs-ci 
lpinca approved these changes Jun 25, 2022
github-actions bot removed the request-ci 
Collaborator
This was referenced Jun 26, 2022
Collaborator
jasnell approved these changes Jun 27, 2022
F3n67u added request-ci 32 tasks
github-actions bot removed the request-ci Collaborator
23 tasks
Collaborator
23 tasks
Collaborator
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in fd1e39f |
16 tasks
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Make sure the histogram containing event loop delay info is posted only when at least one datapoint is collected. Fixes: nodejs/node#43503 PR-URL: nodejs/node#43567 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.
Fixes: #43503