test: improve coverage for load hooks #43374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added esm 
jasnell approved these changes Jun 12, 2022
aduh95 added author ready 
github-actions bot removed the request-ci 
Collaborator
Collaborator
JakobJingleheimer approved these changes Jun 13, 2022
Member
JakobJingleheimer left a comment
JakobJingleheimer left a comment There was a problem hiding this comment.
🙌
Could you add description comments to the blocks in test-esm-loader-thenable.mjs (similar to test-esm-loader-chaining.mjs)
This was referenced Jun 14, 2022
Collaborator
Collaborator
This was referenced Jun 16, 2022
Collaborator
github-actions bot removed the request-ci Collaborator
Collaborator
GeoffreyBooth approved these changes Jun 17, 2022
marsonya approved these changes Jun 17, 2022
Collaborator
34 tasks
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in 29236b5 |
This was referenced Jun 19, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: #43363 (comment) PR-URL: #43374 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 19, 2022
Refs: #43363 (comment) PR-URL: #43374 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #43363 (comment) PR-URL: #43374 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#43363 (comment) PR-URL: nodejs/node#43374 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refs: #43363 (comment)
/cc @nodejs/loaders