vm: allow negative lineOffset and columnOffset in compileFunction #43208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
bnoordhuis reviewed May 26, 2022
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
The change itself LGTM but can you add regression tests?
Member
| 👋 @CathyKMeow! Thanks for your contribution! Looks like somebody else opened a duplicate issue and the fix was merged before this PR was completed. Apologies for the overlap. The fix landed in Node 20. Closing this as a duplicate of #49855 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Solves: #43207