-
- Notifications
You must be signed in to change notification settings - Fork 33.8k
test, url: update WHATWG URL parser to align with latest spec #43190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e399ca to f59e9f5 Compare 382f5ce to 6af706a Compare a0fbe2b to f436d5d Compare 5fd8957 to 3414a08 Compare This comment was marked as outdated.
This comment was marked as outdated.
| @nodejs/url @nodejs/testing |
… and add U+007F to the latter
This comment was marked as outdated.
This comment was marked as outdated.
| This pr got two approvals so I think it is author ready and add the author-ready label. |
| Could you help to rerun just the failed ci? I am tired to rerun Jenkins ci in fresh. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Adding author ready
I understand the frustration, spawning fresh CI is really not a good solution, pinging as you did is a much better solution indeed. |
| wow, CI is green now. could you please land this pr? |
@F3n67u I think you'll be able to land this one yourself by applying the |
| Landed in 2dccda2 |
Thanks. I will try next time. |
PR-URL: #43190 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #43190 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #43190 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: nodejs/node#43190 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
The PR:
git node wpttest-whatwg-url-constructor.js,test-whatwg-url-origin.js, andtest-whatwg-url-setters.jsbecause they are now .any.js in the WPT upstream and covered by wpt testisShadowRealmtoglobal.GLOBALto avoid wpt test crash: without this property test will fail withglobal.GLOBAL.isShadowRealm is not a functionsee https://github.com/web-platform-tests/wpt/blob/master/resources/testharness.js#L544Fix #42920
Fix #41717
Fix #42914: this issue is marked closed by #42915, but #42915 is reverted by #42940, so this issue is still not fixed