meta: add mailmap entry for ShogunPanda #43094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the meta Merged
Trott reviewed May 14, 2022
.mailmap Outdated
Comment on lines 386 to 388
| Paolo Insogna <paolo@cowtech.it> <paolo.insogna@nearform.com> | ||
| Paolo Insogna <paolo@cowtech.it> <shogun@cowtech.it> | ||
| Paolo Insogna <paolo@cowtech.it> <ShogunPanda@users.noreply.github.com> |
Member
There was a problem hiding this comment.
These lines aren't needed unless you plan to commit from those email addresses in the future.
Suggested change
| Paolo Insogna <paolo@cowtech.it> <paolo.insogna@nearform.com> | |
| Paolo Insogna <paolo@cowtech.it> <shogun@cowtech.it> | |
| Paolo Insogna <paolo@cowtech.it> <ShogunPanda@users.noreply.github.com> |
Trott approved these changes May 14, 2022
lpinca approved these changes May 14, 2022
ShogunPanda added the fast-track 
Contributor
| Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
Trott added the commit-queue nodejs-github-bot removed the commit-queue 
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43094 ✔ Done loading data for nodejs/node/pull/43094 ----------------------------------- PR info ------------------------------------ Title meta: add mailmap entry for ShogunPanda (#43094) Author Paolo Insogna (@ShogunPanda) Branch ShogunPanda:mailmap -> nodejs:master Labels meta, fast-track Commits 2 - meta: add mailmap entry for ShogunPanda - meta: respect alphabetical order Committers 1 - Paolo Insogna PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 14 May 2022 05:51:43 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43094#pullrequestreview-973087994 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43094#pullrequestreview-973092919 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2325051169 |
nodejs-github-bot added the commit-queue-failed Trott added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43094 ✔ Done loading data for nodejs/node/pull/43094 ----------------------------------- PR info ------------------------------------ Title meta: add mailmap entry for ShogunPanda (#43094) Author Paolo Insogna (@ShogunPanda) Branch ShogunPanda:mailmap -> nodejs:master Labels meta, fast-track, commit-queue-squash Commits 2 - meta: add mailmap entry for ShogunPanda - meta: respect alphabetical order Committers 1 - Paolo Insogna PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43094 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 14 May 2022 05:51:43 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43094#pullrequestreview-973087994 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43094#pullrequestreview-973092919 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2325080361 |
Member
| Not sure why the Windows stuff is failing in GitHub CI, but I rebased and force-pushed in case the fix is on the master branch. |
Trott approved these changes May 15, 2022
Trott added commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in 8a5657b |
BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43094 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See: #43036 (comment)