deps: upgrade npm to 8.10.0 #43061
Closed
deps: upgrade npm to 8.10.0 #43061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added dont-land-on-v12.x fast-track 
Contributor
| Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
ruyadorno approved these changes May 11, 2022
github-actions bot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
lpinca approved these changes May 11, 2022
VoltrexKeyva approved these changes May 11, 2022
lpinca added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43061 ✔ Done loading data for nodejs/node/pull/43061 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.10.0 (#43061) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-cli-bot:npm-8.10.0 -> nodejs:master Labels npm, fast-track, needs-ci, dont-land-on-v14.x Commits 1 - deps: upgrade npm to 8.10.0 Committers 1 - npm-cli+bot@github.com PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 11 May 2022 17:17:21 GMT ✔ Approvals: 4 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411 ℹ This PR is being fast-tracked ⚠ GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-05-11T18:16:38Z: https://ci.nodejs.org/job/node-test-pull-request/43962/ - Querying data for job/node-test-pull-request/43962/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2334046116 |
Member
| Thanks @wraithgar! |
Contributor
| I clicked the button in the github ui so it did a merge commit, not a rebase. idk if that matters here but now you know. |
Member
| I'm not sure this will work 🤔 I'll go ahead and rebase the commit to be sure 😊 |
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
tniessen removed the commit-queue-failed 28 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
ruyadorno added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43061 ✔ Done loading data for nodejs/node/pull/43061 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.10.0 (#43061) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-cli-bot:npm-8.10.0 -> nodejs:master Labels npm, fast-track, needs-ci, dont-land-on-v14.x Commits 1 - deps: upgrade npm to 8.10.0 Committers 1 - Ruy Adorno PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - deps: upgrade npm to 8.10.0 ℹ This PR was created on Wed, 11 May 2022 17:17:21 GMT ✔ Approvals: 4 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411 ℹ This PR is being fast-tracked ⚠ GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-05-18T14:21:53Z: https://ci.nodejs.org/job/node-test-pull-request/44067/ - Querying data for job/node-test-pull-request/44067/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2346657102 |
Member
| Landed in 06dd8c3. |
lpinca pushed a commit that referenced this pull request May 18, 2022
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This was referenced May 19, 2022
ruyadorno pushed a commit that referenced this pull request May 27, 2022
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
bengl pushed a commit that referenced this pull request May 30, 2022
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol pushed a commit that referenced this pull request Jun 1, 2022
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
This was referenced Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
v8.10.0 (2022-05-11)
Features
911f55d#4864 feat: add --iwr alias for --include-workspace-root (@fritzy)bfb8bcc#4874 feat: add flag --omit-lockfile-registry-resolved (@fritzy) (Caleb ツ Everett)Bug Fixes
48d2db6#4862 fix: remove test coverage map (@wraithgar)38cf29a#4868 fix: cleanup star/unstar (@wraithgar)5baa4a7#4857 fix: consolidate bugs, docs, repo command logic (@wraithgar)5a50762#4875 fix(arborist): link deps lifecycle scripts (@ruyadorno)Dependencies
d58bf40#4856 deps:npm-packlist@5.0.386f443e#4872 deps:make-fetch-happen@10.1.3f9984e6#4880 deps:@npmcli/arborist@5.2.0ba59915#4881 deps:socks-proxy-agent@6.2.0c0806ba#4881 deps:http-proxy-agent@5.0.1cc7be6b#4881 deps:is-core-module@2.9.00432c7d#4881 deps:lru-cache@7.9.05778820#4881 deps:just-diff@5.0.2893dd00#4881 deps:ip@1.1.86ab85bd#4881 deps:builtins@5.0.1