test: add test for profile command of node inspect #43058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
RaisinTen approved these changes May 11, 2022
RaisinTen added the author ready 
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 12, 2022
cjihrig approved these changes May 13, 2022
antsmartian approved these changes May 13, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 14, 2022
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
marsonya approved these changes May 19, 2022
28 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 21, 2022
Member Author
| Could you re-trigger CI and merge? Thank you in advance. |
36 tasks
Collaborator
Collaborator
This was referenced Jun 21, 2022
This was referenced Jun 24, 2022
Collaborator
23 tasks
Collaborator
Collaborator
Collaborator
Collaborator
21 tasks
Collaborator
Collaborator
Collaborator
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in 887816d |
20 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43058 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43058 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43058 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43058 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This test that covers profiler functionalities of
node inspectimproves code coverage oflib/internal/debugger/inspect_repl.js(ref) from 86.9% to 94.11%.