test: reduce flakiness of test-fs-read-position-validation.mjs #42999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
aduh95 reviewed May 7, 2022
aduh95 reviewed May 7, 2022
aduh95 reviewed May 7, 2022
aduh95 reviewed May 7, 2022
aduh95 reviewed May 9, 2022
aduh95 approved these changes May 9, 2022
aduh95 added author ready 
github-actions bot removed the request-ci 
Collaborator
This was referenced May 14, 2022
Merged
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros force-pushed the fs-reads-position-test-segregate branch from 523f1b9 to 11a5b35 Compare Collaborator
aduh95 approved these changes May 15, 2022
aduh95 added commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in e330b45 |
BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
F3n67u pushed a commit to F3n67u/node that referenced this pull request Jun 24, 2022
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`. PR-URL: nodejs#43510 Refs: nodejs#42999 Refs: nodejs#43509 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
| @LiviaMedeiros this breaks tests when landing in v16.x. Do you mind creating a backport PR to v16.x-staging? Thanks |
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
PR-URL: nodejs#42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
PR-URL: nodejs#42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
PR-URL: nodejs#42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
PR-URL: nodejs#42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Backport-PR-URL: nodejs#43588
targos pushed a commit that referenced this pull request Jul 18, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`. PR-URL: nodejs/node#43510 Refs: nodejs/node#42999 Refs: nodejs/node#43509 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The said test failed randomly several times with
EBADFerror code: [1], [2], [3]This PR should make the test more reliable by promisifying Callback API parts and calling them in sequence.
Additionally, it separates Callback API and Synchronous API parts into two tests, in anticipation of validation in Promises API.