stream: add more filter tests #41936
Closed
+69 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
ronag approved these changes Feb 12, 2022
jasnell approved these changes Feb 12, 2022
github-actions bot removed the request-ci 
Collaborator
aduh95 reviewed Feb 12, 2022
| }); | ||
| assert.rejects( | ||
| stream.filter(() => true).toArray(), | ||
| /boom/, |
Contributor
There was a problem hiding this comment.
I think we would want to check the error by reference here, to match the spec proposal text.
Member Author
There was a problem hiding this comment.
I recall this discussion before but I don't recall the conclusion, do you happen to have a reference?
19 tasks
Collaborator
Collaborator
Collaborator
Collaborator
Contributor
| There's a CI failure related to the changes in this PR: |
18 tasks
Member Author
| @aduh95 that's actually not related to this PR - but I can see why that'd happen I'll push a fix (which again is unrelated to this PR). |
github-actions bot removed the request-ci Collaborator
Collaborator
Collaborator
benjamingr added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41936 ✔ Done loading data for nodejs/node/pull/41936 ----------------------------------- PR info ------------------------------------ Title stream: add more filter tests (#41936) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:add-filter-tests -> nodejs:master Labels test, needs-ci Commits 3 - stream: add more filter tests - fixup! - fixup! remove timeout from test Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/41936 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41936 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup! remove timeout from test ℹ This PR was created on Fri, 11 Feb 2022 17:55:59 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880871183 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880872056 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880887559 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-02-14T14:26:06Z: https://ci.nodejs.org/job/node-test-pull-request/42554/ - Querying data for job/node-test-pull-request/42554/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1842083455 |
nodejs-github-bot added the commit-queue-failed benjamingr added a commit that referenced this pull request Feb 14, 2022
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member Author
| Forgot to autosquash, meh, landed manually :) Landed in da11381 🎉 |
Contributor
FYI you can use commit-queue-squash |
Member Author
| Thanks, yeah, I forgot to use that and already had a terminal open with node so I just landed with ncu :) |
This was referenced Feb 15, 2022
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
PR-URL: nodejs#41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
PR-URL: nodejs#41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bengl pushed a commit that referenced this pull request Feb 21, 2022
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bengl pushed a commit that referenced this pull request Feb 22, 2022
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Contributor
| @benjamingr this breaks when landing on v16.x-staging. Can you open a backport PR to land on v16.x? Thank you |
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add more tests to Readable.prototype.filter
cc @nodejs/streams @aduh95