test: simplify test-gc-http-client #41620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead of sending a fixed number of requests, detect when GC has started and stop sending requests at that point. Refs: nodejs@47ecf2060343
nodejs-github-bot added needs-ci 
Trott approved these changes Jan 20, 2022
cjihrig approved these changes Jan 21, 2022
github-actions bot removed the request-ci 
Collaborator
13 tasks
Collaborator
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41620 ✔ Done loading data for nodejs/node/pull/41620 ----------------------------------- PR info ------------------------------------ Title test: simplify test-gc-http-client (#41620) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:simplify/test-gc-http-client -> nodejs:master Labels test, needs-ci Commits 1 - test: simplify test-gc-http-client Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/41620 Refs: https://github.com/nodejs/node/commit/47ecf2060343 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41620 Refs: https://github.com/nodejs/node/commit/47ecf2060343 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 20 Jan 2022 19:23:20 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41620#pullrequestreview-858921249 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41620#pullrequestreview-859013732 ✖ GitHub CI is still running ℹ Last Full PR CI on 2022-01-23T07:05:39Z: https://ci.nodejs.org/job/node-test-pull-request/42096/ - Querying data for job/node-test-pull-request/42096/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1736876040 |
nodejs-github-bot added the commit-queue-failed Member Author
| Landed in 7ce8403. |
lpinca added a commit that referenced this pull request Jan 23, 2022
Instead of sending a fixed number of requests, detect when GC has started and stop sending requests at that point. PR-URL: #41620 Refs: 47ecf2060343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jan 24, 2022
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
Instead of sending a fixed number of requests, detect when GC has started and stop sending requests at that point. PR-URL: #41620 Refs: 47ecf2060343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jan 26, 2022
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Instead of sending a fixed number of requests, detect when GC has started and stop sending requests at that point. PR-URL: nodejs#41620 Refs: nodejs@47ecf2060343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
Instead of sending a fixed number of requests, detect when GC has started and stop sending requests at that point. PR-URL: #41620 Refs: 47ecf2060343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
Instead of sending a fixed number of requests, detect when GC has started and stop sending requests at that point. PR-URL: #41620 Refs: 47ecf2060343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
Instead of sending a fixed number of requests, detect when GC has started and stop sending requests at that point. PR-URL: #41620 Refs: 47ecf2060343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instead of sending a fixed number of requests, detect when GC has
started and stop sending requests at that point.
Refs: 47ecf2060343