build: add loong64 configure #41323
Merged
build: add loong64 configure #41323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Review requested:
|
nodejs-github-bot added build 
targos approved these changes Dec 28, 2021
tniessen approved these changes Dec 28, 2021
targos added author ready 
github-actions bot removed the request-ci Collaborator
Member
| cc @nodejs/build |
rvagg reviewed Jan 3, 2022
| 'android', 'aix', 'cloudabi') | ||
| valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el', 'ppc', | ||
| 'ppc64', 'x32','x64', 'x86', 'x86_64', 's390x', 'riscv64') | ||
| 'ppc64', 'x32','x64', 'x86', 'x86_64', 's390x', 'riscv64', |
Member
There was a problem hiding this comment.
once upon a time these entries were sorted, it's not critical but maybe while you're in here you could fix up these last 3 entries
richardlau approved these changes Jan 4, 2022
Collaborator
jasnell approved these changes Jan 17, 2022
github-actions bot removed the request-ci Collaborator
mmarchini approved these changes Jan 18, 2022
Collaborator
richardlau added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in 81e88f2 |
This was referenced Jan 19, 2022
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
PR-URL: #41323 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41323 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
v8 had been add loong64 backend, this commit add loong64 build configure.