[v14.x]: deps: V8: Add Power9/10 to the supported list and enable related features #38508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added build 
Collaborator
aduh95 changed the title 
miladfarca requested review from richardlau and targos and removed request for targos 
richardlau approved these changes May 3, 2021
AshCripps approved these changes May 4, 2021
danielleadams force-pushed the v14.x-staging branch from 23ede20 to f755fc4 Compare Collaborator
Author
| @richardlau Similar to #38509, I don't think I will be able to land this on my own either. |
Member
| Yes, only members of the backporters and/or release team can land on the staging branches. I'll land this if the CI's currently in progress pass. |
richardlau approved these changes May 14, 2021
richardlau pushed a commit that referenced this pull request May 14, 2021
Original commit message: ``` PPC: Add Power10 to the supported list and enable related features This CL adds Power10 recognition to Linux, AIX as well as IBMi. Enabled features include: MODULO FPR_GPR_MOV SIMD LWSYNC ISELECT VSX Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041 Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Junliang Yan <junyan@redhat.com> Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74279} ``` Refs: v8/v8@530080c PR-URL: #38508 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
| Landed in d678277. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please note that enum values are slightly different from V8 upstream, i.e
PPC_POWER10instead ofkPPCPower10.Power 9 is also added to some of the features within the ppc assembler, this is to make adding P10 consistent and is not part of the original CL on V8.
We have SIMD enabled upstream which will not be backported here.
Refs: v8/v8@530080c