doc: indicate that abort tests do not generate core files #38422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README.
addaleax approved these changes Apr 26, 2021
github-actions bot added needs-ci 
richardlau approved these changes Apr 26, 2021
cjihrig approved these changes Apr 27, 2021
jasnell approved these changes Apr 27, 2021
gireeshpunathil approved these changes Apr 27, 2021
jasnell pushed a commit that referenced this pull request Apr 28, 2021
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: #38422 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
| Landed in d037039 |
targos pushed a commit that referenced this pull request Apr 29, 2021
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: #38422 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request May 30, 2021
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: #38422 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: #38422 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: #38422 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: #38422 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The key thing about the tests in
test/abortis that tests in thatdirectory do not generate core files (thanks to testcfg.py). Make a note
of that in the test README.