stream: fix multiple Writable.destroy() calls. #38221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189
Member Author
| @nodejs/streams |
lpinca approved these changes Apr 13, 2021
ronag added the author ready 
Collaborator
Member
Collaborator
Linkgoron approved these changes Apr 13, 2021
Collaborator
Trott approved these changes Apr 14, 2021
Member
| @ronag ... looks like this has a linter issue |
jasnell removed the author ready Member Author
| Just needs another CI run. |
ronag added the author ready Collaborator
Member Author
| Landed in 369f239 |
ronag added a commit that referenced this pull request Apr 16, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Contributor
| @ronag do you mind opening a Backport PR for this for |
ronag added a commit to nxtedition/node that referenced this pull request Apr 29, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ronag added a commit to nxtedition/node that referenced this pull request Apr 29, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ronag added a commit to nxtedition/node that referenced this pull request Apr 29, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#38473
Member Author
ronag added a commit to nxtedition/node that referenced this pull request Apr 29, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#38473
ronag added a commit to nxtedition/node that referenced this pull request Apr 29, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#38473
targos pushed a commit that referenced this pull request May 30, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos pushed a commit that referenced this pull request Jun 5, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos pushed a commit that referenced this pull request Jun 5, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos pushed a commit that referenced this pull request Jun 11, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Calling Writable.destroy() multiple times in the same tick
could cause an assertion error.
Fixes: #38189